Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant push permissions to Benchmark.yml #90

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Grant push permissions to Benchmark.yml #90

merged 1 commit into from
Sep 10, 2024

Conversation

penelopeysm
Copy link
Member

@yebai I'm cautiously optimistic this might work :)

@yebai
Copy link
Member

yebai commented Sep 10, 2024

Thanks, @penelopeysm -- works like a charm!

@yebai yebai merged commit b8b1d76 into master Sep 10, 2024
9 of 10 checks passed
@yebai yebai deleted the pysm/gha-perms branch September 10, 2024 11:11
@yebai
Copy link
Member

yebai commented Sep 10, 2024

@penelopeysm it seems like https://github.com/TuringLang/AdvancedVI.jl/actions/runs/10791262052/job/29928290483 failed again, even after incorporating changes from this PR.

@penelopeysm
Copy link
Member Author

Oh, I keep getting caught out by this. It's probably because that PR is coming from a fork, and github won't give that PR permission to push to a branch.

@yebai
Copy link
Member

yebai commented Sep 10, 2024

Thanks, @penelopeysm. Can you modify the benchmarks CI to skip uploading for PRs from forks?

@Red-Portal can you create branches from this repo in the future so we don't run into Ci permission issues?

@Red-Portal
Copy link
Member

Thank you all for the work. I'll do it the suggested way in the future. Though external PRs will probably suffer from the permission issues still.

@penelopeysm
Copy link
Member Author

Hmmm. I just got a chance to look at it a bit more closely. My inclination is that the workflow should only push to gh-pages for commits that are on the main branch?

Otherwise, if we update the benchmark JSON file for every PR/commit, the regression test (alert-threshold > 200%) won't run against main, but rather against whichever commit someone else last pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants