Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for SimpleUnPack at version 1 for package bench, (keep existing compat) #118

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 5, 2024

This pull request sets the compat entry for the SimpleUnPack package to 1 for package bench.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2024-10-05-00-21-36-312-01124661024 branch from 2deebca to f9ee299 Compare October 5, 2024 00:21
Copy link
Contributor Author

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: f9ee299 Previous: 964b5fb Ratio
normal + bijector/meanfield/ForwardDiff 458742373 ns 492049709 ns 0.93
normal + bijector/meanfield/ReverseDiff 195143033.5 ns 198254996.5 ns 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@Red-Portal Red-Portal closed this Oct 5, 2024
@yebai yebai deleted the compathelper/new_version/2024-10-05-00-21-36-312-01124661024 branch October 21, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant