Added support for models using the LogDensityProblems.jl interface #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this in after tests pass |
|
Tests are failing because we're still testing on Julia 1.0, let me fix that. |
|
🥳 Thank you, @torfjelde! |
devmotion
reviewed
Dec 28, 2022
| @@ -68,6 +68,24 @@ Quantiles | |||
|
|
|||
| ``` | |||
|
|
|||
| ### Usage with [`LogDensityProblems.jl`](https://github.com/tpapp/LogDensityProblems.jl) | |||
|
|
|||
| It can also be used with models defining the [`LogDensityProblems.jl`](https://github.com/tpapp/LogDensityProblems.jl) interface by wrapping it in `AbstractMCMC.LogDensityModel` before passing it to `sample`: | |||
There was a problem hiding this comment.
Is it really necessary to wrap the log density? Couldn't we wrap anything in a LogDensityModel that's not one of our specialized model types? We could even check LogDensityProblems.capabilities !== nothing to ensure that we do not wrap anything accidentally that does not implement the interface.
That means this PR should have bumped Julia compat to 1.6, shouldn't it? |
|
Oops, thanks for catching that, @devmotion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it's possible to use models implementing the LogDensityProblems.jl interface. This is now easy to support after TuringLang/AbstractMCMC.jl#110.
Similar PR merged for AHMC.jl: TuringLang/AdvancedHMC.jl#301