-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying trajectories #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just address my one comment. And, though it's not directly related to this PR, after we completely remove the NUTS struct it would still be useful to have a NUTS method which simply constructs the corresponding Trajectory
so that people who aren't too familiar with the topic find what they expect.
Also, I really like this work:)
CI passed now and it's ready for a final look @yebai |
The only CI which "fails" due to running out of time. |
To be safe I just triggered a re-run of all CI. Let's see how it goes this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work - many thanks to Kai! I left some minor comments below.
ClassicNoUTurn, GeneralisedNoUTurn, | ||
StrictGeneralisedNoUTurn, | ||
export Trajectory, | ||
FixedNSteps, FixedIntegrationTime, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe consider unifying these type names in a future PR, e.g. FixedNSteps
==> FixedIntegrationSteps
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created an issue for this and some other potential naming improvements #246.
Is this good to go? |
This PR unifies all trajectories under the same interface.
For example, NUTS shall be constructed by:
Old constructors are supported but deprecated.
Besides, the way to unify
FixedNSteps
andFixedIntegrationTime
is via a new-introducednsteps(::Trajectory)
, suggested by @torfjelde.FixedIntegrationTime
was converted toFixedNSteps
before callingtransition
, andtermination_criterion.L
appears here and there, which is not ideal.