Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: Do not re-evaluate procedure arguments after stop this script or return #202

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

GarboMuffin
Copy link
Member

Fixes #201

Also fixes this causing two requests to translate service (same bug):

image

…cript or return

"stop this script" and "return" would previously cause all the procedure
arguments to be re-evaluated and then discarded. In vanilla Scratch the
worst case is a performance penalty, but with our custom reporters it
can cause infinite loops.

Fixes #201
@AshimeeAlt
Copy link

yay

@GarboMuffin GarboMuffin merged commit 20f25f2 into develop Mar 30, 2024
2 checks passed
@GarboMuffin GarboMuffin deleted the fix-201 branch March 30, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom reporters can hang browser in certain situations.
2 participants