Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptReporters to more inputs. #191

Closed

Conversation

LilyMakesThings
Copy link

Proposed Changes

Add an acceptReporters option for argument placeholders.

Reason for Changes

TurboWarp's argument types currently always allow for reporters to be accepted. Other features, like event-based hats, are exclusively limited to discriminating by fields.

Some features do require the input/customisation of a user, but without it changing in real-time with, for example a variable reporter.

Allowing for fields to be directly inside of blocks would also open up more customisation for extension developers.

It also feels more intuitive for acceptReporters to apply to every type of input, not just menus; we can have menus be only sometimes able to accept reporters (kind of like the broadcast menu/field).

Test Coverage

Haven't touched actual tests.

Known Problems

  • Colours are messed up.
  • Isn't compatible with fields aside from the text-based ones.

@LilyMakesThings LilyMakesThings changed the title Update runtime.js Add acceptReporters to more inputs. Feb 3, 2024
@LilyMakesThings LilyMakesThings marked this pull request as ready for review February 6, 2024 00:54
@LilyMakesThings
Copy link
Author

I'm not going to work on the other changes I mentioned. If this is merged I'll submit another PR, and if it isn't I'll add onto it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant