Add acceptReporters to more inputs. #191
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add an acceptReporters option for argument placeholders.
Reason for Changes
TurboWarp's argument types currently always allow for reporters to be accepted. Other features, like event-based hats, are exclusively limited to discriminating by fields.
Some features do require the input/customisation of a user, but without it changing in real-time with, for example a variable reporter.
Allowing for fields to be directly inside of blocks would also open up more customisation for extension developers.
It also feels more intuitive for acceptReporters to apply to every type of input, not just menus; we can have menus be only sometimes able to accept reporters (kind of like the broadcast menu/field).
Test Coverage
Haven't touched actual tests.
Known Problems