Fix rx and ry element problems
#4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyMakesThings
approved these changes
Jul 14, 2024
This comment was marked as spam.
This comment was marked as spam.
|
I think this is the wrong layer to fix it in |
|
Which should I do it in instead? I couldn't decide between the file upload handler in the GUI, the svg fix file in the GUI, and this file. Let me know, and I'll open a new PR it the designated location. |
This comment was marked as spam.
This comment was marked as spam.
|
since only paper.js can't understand, patch paper.js |
|
There's a PR by someone to fix the problem that literally dates back to 2020. Still hasn't been merged. |
|
Great then send it to TurboWarp/paper.js |
|
Alright, I'll move it over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, paper.js ignores lone
rxorryelements in an SVG, causing it to fail to render properly in the paint editor.This PR checks the SVG for the existence of either element and the non existence of the other respectively, and adds it.
Currently known SVG makers that have the problem of only exporting with one of the aforementioned elements are Figma and Adobe XD.
Example SVG to test:
