core/field_dropdown : always return something. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyMakesThings
changed the title
GarboMuffin
reviewed
Feb 10, 2024
Don't know which method is the most tasteful in this case so I just went with the one I already knew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
This common error when a menu receives a completely empty array.
Proposed Changes
Have getOptions always return an array with at least a blank string.
Reason for Changes
This error is commonly found among following steps in the TurboWarp extension documentation. Especially for people working with the much less documented dynamic menus, you wouldn't expect such a common case to be the cause of this.
It's not entirely obvious or logical that this would be caused by an empty menu, especially when it should be handled internally.
Test Coverage
None.