-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge further improvements submitted to my fork #15
base: master
Are you sure you want to change the base?
Conversation
fix allow_metadata_inventory_move so that it doesnt crash
Sorry I didn't see this PR earlier. Very good job, thank you!
There's just no way I can accept this PR. I'm not gonna go through each of these changes to check for further issues. There could be numerous problems in all this mess, and tbh I do not have the time to go through it all one by one. |
I'll look into what happens with groups (I tested on creative and on v4 back in October, which obviously could hide the issue you're seeing today), but otherwise most changes in the PR must be purely cosmetic. Indentation and such. |
Just to make you aware, I have been getting ready to offer some of my mods (this one included) over to minetest_mods, because I have had less and less time, to fiddle these days. So anything being presented currently will have to remain on hold until I get these over there. So I'm not leaving you or anyone else hanging.. I just need to get these things somewhere they can get better attention Thank you |
@@ -0,0 +1,2 @@ | |||
facade.in_creative_inventory (Facades show in inventory) bool true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facade.in_creative_inventory (Facades show in inventory) bool true | |
facade.in_creative_inventory (Enable facades in creative inventory) bool true |
@@ -0,0 +1,2 @@ | |||
facade.in_creative_inventory (Facades show in inventory) bool true | |||
facade.protect_inventories (Facade shaper is protected) bool false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
facade.protect_inventories (Facade shaper is protected) bool false | |
facade.protect_inventories (Enable shaper protection) bool false |
fluxionary greatly improved the code of the mod recently, so I'm propagating these changes to upstream. A lot of redundancy in definitions has been removed overall.