[ACL-242] Add CreditableAt in GetPaymentResult #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dili91
reviewed
Dec 11, 2024
| /// </summary> | ||
| /// <returns></returns> | ||
| [JsonDiscriminator("authorized")] | ||
| public record Authorized : PaymentDetails; | ||
| public record Authorized(DateTime? CreditableAt) : PaymentDetails; |
There was a problem hiding this comment.
Is this correct? It does not seems so based on our public docs? I can't see the field on the authorized payment details on the API ref
There was a problem hiding this comment.
yeah, it's quite new, probably the docs are not updated, I'm checking with Risk
There was a problem hiding this comment.
It's confirmed, we need to update docs
dili91
reviewed
Dec 11, 2024
| _httpClient = httpClient; | ||
| } | ||
|
|
||
| public async Task<Uri> AuthorisePaymentAsync( |
There was a problem hiding this comment.
yeah, I was planning to do a refactor later, we can optimise several part of the tests.
The problem with this method was that returns a GetPaymentResponse.PaymentDetails and we need the specific type of the GetPaymentResponse for this test.
dili91
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CreditableAt in
Authorized,ExecutedandSettledcase ofGetPayment.Added test for GetPayment when status is
Settled