[ACL-231] Support for generate idempotency keys when not provided #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tl-Roberto-Mancinelli
commented
Nov 27, 2024
•
tl-Roberto-Mancinelli
commented
- Changed idempotency key to nullable type and automatically generate a uuid in case of null
- Remove netcore 3.1 from test as it's causing warnings
- Switched to mock-payments-gb-redirect for VRP commercial tests
- Minor improvements in ci
tl-Roberto-Mancinelli
changed the title
tl-Roberto-Mancinelli
force-pushed
the
ACL-231
branch
from
fba33ef to
af1d1dc
Compare
tl-Roberto-Mancinelli
force-pushed
the
ACL-231
branch
2 times, most recently
from
c684d91 to
3214d0c
Compare
tl-Roberto-Mancinelli
force-pushed
the
ACL-231
branch
from
3214d0c to
0d047e7
Compare
dili91
reviewed
Dec 20, 2024
Comment on lines
+20
to
+22
| with: | ||
| fetch-depth: 0 | ||
| filter: tree:0 |
There was a problem hiding this comment.
What's the benefit of this?
There was a problem hiding this comment.
it's required for minver
dili91
reviewed
Dec 20, 2024
| @@ -65,7 +71,10 @@ public async Task<ApiResponse<CreateMandateResponse>> CreateMandate(CreateMandat | |||
|
|
|||
| //TODO: is it correct that this method expects a mandate type? | |||
| /// <inheritdoc /> | |||
| public async Task<ApiResponse<MandateDetailUnion>> GetMandate(string mandateId, MandateType mandateType, CancellationToken cancellationToken = default) | |||
| public async Task<ApiResponse<MandateDetailUnion>> GetMandate( | |||
There was a problem hiding this comment.
One day it would be nice standardising the handling for scopes across libs. I think we should also start from the API and re-assess if using scopes to segregate type of mandates is correct... It does not seem to be very inline with Oauth?
There was a problem hiding this comment.
That's something we considered, it will be nice to remove those scopes
dili91
reviewed
Dec 20, 2024
| public static string COMMERCIAL_PROVIDER_ID = "ob-natwest-vrp-sandbox"; // Provider to satisfy commercial mandates creation. | ||
| public static AccountIdentifier.SortCodeAccountNumber accountIdentifier = new("140662", "10003957"); | ||
| private const string ReturnUri = "http://localhost:3000/callback"; | ||
| private const string ProviderId = "ob-uki-mock-bank-sbox"; // Beta provider in closed access, requires a whitelisted ClientId. |
dili91
reviewed
Dec 20, 2024
| public static AccountIdentifier.SortCodeAccountNumber accountIdentifier = new("140662", "10003957"); | ||
| private const string ReturnUri = "http://localhost:3000/callback"; | ||
| private const string ProviderId = "ob-uki-mock-bank-sbox"; // Beta provider in closed access, requires a whitelisted ClientId. | ||
| private const string CommercialProviderId = "mock-payments-gb-redirect"; // Provider to satisfy commercial mandates creation. |
There was a problem hiding this comment.
Is it just for commercial? could we use this for both sweeping and commercial?
There was a problem hiding this comment.
no, it doesn't work with the current implementation of the tests.
A refactor of mandate tests is needed to use that mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.