-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mandates APIs #185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we don't have a Common namespace, unlike the Java SDK
… Failure Stage to ensure only correct values are passed in.
…n I changed "Status" back to a string. OneOf does still work to allow creating a subtype of MandateDetails enven though it uses 'status' instead of 'type' as its discriminator as OneOfJsonConverter has a hack to allow it.
…tje models differ slightly, and this is how it was done in the Java SDK. Nested union types in static classes.
…eem to handle this ok. The Java SDK has it as snake case here for some reason but nowhere else. Also used DateTime rather than string as that seems to be common in the .NET SDK, but inconsistent in Java. The format isn't always listed in the docs, or is inconsistent between endpoints.
… the other is wrong.
…two kind of confusingly named variations which are used separately for creating and getting constraints.
…garding open questions around discrepancies with API docs / Java SDK
…raints Release GetMandateConstraints and RevokeMandate
…aints Merge latest release changes into main
Mandate API endpoints: submit consent
Release SubmitConsent
Support for the Mandate Method in the Payment API
Release Mandate Payment Method
Release Mandate Payment Method branch changes
ApiResponse public constructors
…ructors Release ApiResponse public constructors
tl-antonio-valentini
approved these changes
Oct 16, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs 71.2% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the sum of the following PRs (already reviewed and approved):
Extra: