Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mandates APIs #185

Merged
merged 145 commits into from
Oct 17, 2023
Merged

Implement mandates APIs #185

merged 145 commits into from
Oct 17, 2023

Conversation

tl-mauro-franchi
Copy link
Contributor

@tl-mauro-franchi tl-mauro-franchi commented Sep 4, 2023

TANDEM\ryan.palmer and others added 30 commits July 12, 2023 15:17
… we don't have a Common namespace, unlike the Java SDK
… Failure Stage to ensure only correct values are passed in.
…n I changed "Status" back to a string. OneOf does still work to allow creating a subtype of MandateDetails enven though it uses 'status' instead of 'type' as its discriminator as OneOfJsonConverter has a hack to allow it.
…tje models differ slightly, and this is how it was done in the Java SDK. Nested union types in static classes.
…eem to handle this ok. The Java SDK has it as snake case here for some reason but nowhere else. Also used DateTime rather than string as that seems to be common in the .NET SDK, but inconsistent in Java. The format isn't always listed in the docs, or is inconsistent between endpoints.
…two kind of confusingly named variations which are used separately for creating and getting constraints.
…garding open questions around discrepancies with API docs / Java SDK
@tl-mauro-franchi tl-mauro-franchi marked this pull request as ready for review October 16, 2023 14:05
@tl-mauro-franchi tl-mauro-franchi requested a review from a team as a code owner October 16, 2023 14:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

71.2% 71.2% Coverage
1.8% 1.8% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tl-mauro-franchi tl-mauro-franchi merged commit 47a4e49 into main Oct 17, 2023
3 checks passed
@tl-Roberto-Mancinelli tl-Roberto-Mancinelli deleted the tandem/mandates branch December 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants