add missing guards; add runtime version

TrueLayer · Dec 23, 2024 · 59b31ac · 59b31ac
1 parent 1376533
commit 59b31ac
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/src/TrueLayer/ApiClient.cs b/src/TrueLayer/ApiClient.cs
@@ -24,8 +24,7 @@ namespace TrueLayer
     internal class ApiClient : IApiClient
     {
         private static readonly string TlAgentHeader
-            = $"truelayer-dotnet/{ReflectionUtils.GetAssemblyVersion<ITrueLayerClient>()}";
-
+            = $"truelayer-dotnet/{ReflectionUtils.GetAssemblyVersion<ITrueLayerClient>()} ({System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription})";
         private readonly HttpClient _httpClient;
         private readonly IAuthTokenCache _authTokenCache;
 
@@ -46,7 +45,6 @@ public async Task<ApiResponse<TData>> GetAsync<TData>(
             IDictionary<string, string>? customHeaders = null,
             CancellationToken cancellationToken = default)
         {
-
             using var httpResponse = await SendRequestAsync(
                 httpMethod: HttpMethod.Get,
                 uri: uri,

diff --git a/src/TrueLayer/Payments/PaymentsApi.cs b/src/TrueLayer/Payments/PaymentsApi.cs
@@ -110,6 +110,7 @@ public async Task<ApiResponse<AuthorizationResponseUnion>> StartAuthorizationFlo
             CancellationToken cancellationToken = default)
         {
             paymentId.NotNullOrWhiteSpace(nameof(paymentId));
+            paymentId.NotAUrl(nameof(paymentId));
             idempotencyKey.NotNullOrWhiteSpace(nameof(idempotencyKey));
             request.NotNull(nameof(request));
 
@@ -135,6 +136,7 @@ public async Task<ApiResponse<CreatePaymentRefundResponse>> CreatePaymentRefund(
             string idempotencyKey, CreatePaymentRefundRequest request, CancellationToken cancellationToken = default)
         {
             paymentId.NotNullOrWhiteSpace(nameof(paymentId));
+            paymentId.NotAUrl(nameof(paymentId));
             request.NotNull(nameof(request));
 
             var authResponse = await _auth.GetAuthToken(
@@ -155,10 +157,12 @@ public async Task<ApiResponse<CreatePaymentRefundResponse>> CreatePaymentRefund(
             );
         }
 
-        public async Task<ApiResponse<ListPaymentRefundsResponse>> ListPaymentRefunds(string paymentId,
+        public async Task<ApiResponse<ListPaymentRefundsResponse>> ListPaymentRefunds(
+            string paymentId,
             CancellationToken cancellationToken = default)
         {
             paymentId.NotNullOrWhiteSpace(nameof(paymentId));
+            paymentId.NotAUrl(nameof(paymentId));
 
             var authResponse = await _auth.GetAuthToken(
                 new GetAuthTokenRequest(AuthorizationScope.Payments), cancellationToken);
@@ -175,11 +179,15 @@ public async Task<ApiResponse<ListPaymentRefundsResponse>> ListPaymentRefunds(st
             );
         }
 
-        public async Task<ApiResponse<RefundUnion>> GetPaymentRefund(string paymentId,
-            string refundId, CancellationToken cancellationToken = default)
+        public async Task<ApiResponse<RefundUnion>> GetPaymentRefund(
+            string paymentId,
+            string refundId,
+            CancellationToken cancellationToken = default)
         {
             paymentId.NotNullOrWhiteSpace(nameof(paymentId));
+            paymentId.NotAUrl(nameof(paymentId));
             refundId.NotNullOrWhiteSpace(nameof(refundId));
+            refundId.NotAUrl(nameof(refundId));
 
             var authResponse = await _auth.GetAuthToken(
                 new GetAuthTokenRequest(AuthorizationScope.Payments), cancellationToken);
@@ -199,6 +207,7 @@ public async Task<ApiResponse<RefundUnion>> GetPaymentRefund(string paymentId,
         public async Task<ApiResponse> CancelPayment(string paymentId, string idempotencyKey, CancellationToken cancellationToken = default)
         {
             paymentId.NotNullOrWhiteSpace(nameof(paymentId));
+            paymentId.NotAUrl(nameof(paymentId));
             idempotencyKey.NotNullOrWhiteSpace(nameof(idempotencyKey));
 
             var authResponse = await _auth.GetAuthToken(

diff --git a/test/TrueLayer.Tests/ApiClientTests.cs b/test/TrueLayer.Tests/ApiClientTests.cs
@@ -262,7 +262,7 @@ public async Task Sets_TL_agent_header()
         {
             _httpMessageHandler
                 .Expect(HttpMethod.Get, "http://localhost/user-agent")
-                .WithHeaders(CustomHeaders.Agent, $"truelayer-dotnet/{ReflectionUtils.GetAssemblyVersion<ApiClient>()}")
+                .WithHeaders(CustomHeaders.Agent, $"truelayer-dotnet/{ReflectionUtils.GetAssemblyVersion<ApiClient>()} ({System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription})")
                 .Respond(HttpStatusCode.OK, MediaTypeNames.Application.Json, "{}");
 
             var response = await _apiClient.GetAsync<TestResponse>(new Uri("http://localhost/user-agent"));