Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress Notes Frontend & Backend #102

Merged
merged 23 commits into from
May 21, 2024
Merged

Progress Notes Frontend & Backend #102

merged 23 commits into from
May 21, 2024

Conversation

aaronchan32
Copy link
Member

@aaronchan32 aaronchan32 commented May 13, 2024 •
edited
Loading

Tracking Info

Resolves #75

Changes

  • Added backend routes to get, add, edit, and delete progress notes with authentication and authorization checks
  • Added account type limitations for progress notes (Admin: add, edit, delete, download | Test: add) on frontend and backend
  • Wrapped app with ProgramsContextProvider based on Parth's implementation so initial programs fetch data is shared between home, programs, and notes page
  • Added svgr/webpack package to automatically transform SVGs into react components
  • Added support for filtering by programs (Using Parth's ProgramFilter) and filtering by student name or notes
  • Added support for downloading progress notes using react-pdf package
  • Adjusted styling across pages to be more consistent and included new loading animation (used img instead of svg because SVGs don't support angular gradients but we can fix this in the future)

Testing

  • All features can be tested on the notes page
  • Tested adding new progress note
  • Tested editing new progress note by clicking on the pencil icon on the right in list view mode or clicking on pencil icon in the top right when viewing a specific note
  • Tested deleting new progress note and undoing it
  • Tested downloading PDF
  • Tested all of the above on both Team and Admin accounts
  • Tested UI when there are no students and no progress notes
  • Tested filtering by programs and filtering by student name/notes

Confirmation of Change

image

Additional Notes

  • The current Button component can accept tailwind classnames that are overridden by the module css styles
  • Progress Notes PDF
    • text on the same line as an emoji is forced to have a font family of Arial
    • react-pdf only supports TTF fonts and I had issues getting our header font Alternate Gothic to work

@aaronchan32
feat: add create program notes backend
52b9c3c
@aaronchan32
fix: THead unique key prop warning
bf8e682
@aaronchan32
feat: add edited by field to notes
b282836
@aaronchan32
fix: fix styling issues
f895805
@aaronchan32
feat: add edit and delete functionality to progress notes and change …
351c445 
…userId to uid for backend
@aaronchan32
fix: fix calendar styling
1d2d520
@aaronchan32
feat: add download progress notes functionality using react-pdf
b3cf525
@aaronchan32
feat: add mobile responsiveness
d6ed60f
@aaronchan32
Merge branch 'main' of https://github.com/TritonSE/PIA-Program-Manager …
d13740f 
…into feature/aaronchan32/progress-notes
@aaronchan32
feat: create program context provider shared across Home, Programs, a…
230b01e 
…nd Notes page
@aaronchan32
fix: fix styling to be consistent across pages
953d0c3
@aaronchan32
feat: add progress note filtering and add loading spinner to pages
b19253c
@aaronchan32
feat: add account type authorization checks on frontend and backend
d05157e
@aaronchan32
refactor: refactor notes logic and fix styling
a70c342
@aaronchan32
feat: add logic to check for no students and refactor filter
831fdf3
@aaronchan32
feat: add shadows using overflow clip
a93c0f6
@aaronchan32
fix: fix styling for search filter
a6d57f7
@aaronchan32 aaronchan32 self-assigned this May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1c59338):

https://pia-dev-60cea--pr102-feature-aaronchan32-f7vow9ck.web.app

(expires Tue, 28 May 2024 21:35:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

aaronchan32 and others added 2 commits May 20, 2024 01:27
@aaronchan32
Squashed commit of the following:
e078081 
commit 0b133b8
Author: Michael Sullivan <[email protected]>
Date:   Tue May 14 09:09:16 2024 -0700

    Feature/mraysu/program form v2 (#100)

    * Update Backend Program Schema

    * V2 UI

    * Disabled Editing Program Type

    * Frontend-backend integration

    * Lint fixes

    ---------

    Co-authored-by: mraysu <[email protected]>
    Co-authored-by: Adhithya Ananthan <[email protected]>

commit e17b509
Author: parth4apple <[email protected]>
Date:   Tue May 14 09:01:15 2024 -0700

    Student and Enrollment Schema modifications (#101)

    * feat: initial schema

    * feat: edit routes

    * feat: test and fix routes
@adhi0331
Merge branch 'main' into feature/aaronchan32/progress-notes
1c59338
adhi0331
adhi0331 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🚀

@adhi0331 adhi0331 merged commit b8865a7 into main May 21, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/aaronchan32/progress-notes branch May 21, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhi0331 adhi0331 adhi0331 approved these changes

Assignees

@aaronchan32 aaronchan32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EPIC] - Progress Notes
2 participants
@aaronchan32 @adhi0331