Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mraysu/program form v2 #100

Merged
merged 7 commits into from
May 14, 2024
Merged

Conversation

mraysu
Copy link
Contributor

@mraysu mraysu commented May 6, 2024

Changes

  • updated program schema
  • updated program form ui to match updated schema
  • removed ability to change program type after creation
  • program abbreviations must be unique
  • cleaned up a bunch of redundant code

Note that a bunch of features using old startDate, endDate, renewalDate, and students fields have been temporarily altered/disabled

Testing

Tested frontend-backend route using program form and postman
image
image
image

Confirmation of Change

image
image

Copy link

github-actions bot commented May 6, 2024

Visit the preview URL for this PR (updated for commit aef3d8b):

https://pia-dev-60cea--pr100-feature-mraysu-progr-whrzcp3z.web.app

(expires Tue, 21 May 2024 16:06:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🚀

@adhi0331 adhi0331 merged commit 0b133b8 into main May 14, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/mraysu/program-form-v2 branch May 14, 2024 16:09
aaronchan32 added a commit that referenced this pull request May 20, 2024
commit 0b133b8
Author: Michael Sullivan <[email protected]>
Date:   Tue May 14 09:09:16 2024 -0700

    Feature/mraysu/program form v2 (#100)

    * Update Backend Program Schema

    * V2 UI

    * Disabled Editing Program Type

    * Frontend-backend integration

    * Lint fixes

    ---------

    Co-authored-by: mraysu <[email protected]>
    Co-authored-by: Adhithya Ananthan <[email protected]>

commit e17b509
Author: parth4apple <[email protected]>
Date:   Tue May 14 09:01:15 2024 -0700

    Student and Enrollment Schema modifications (#101)

    * feat: initial schema

    * feat: edit routes

    * feat: test and fix routes
adhi0331 added a commit that referenced this pull request May 21, 2024
* feat: add create program notes backend

* fix: THead unique key prop warning

* feat: add edited by field to notes

* fix: fix styling issues

* feat: add edit and delete functionality to progress notes and change userId to uid for backend

* fix: fix calendar styling

* feat: add download progress notes functionality using react-pdf

* feat: add mobile responsiveness

* feat: create program context provider shared across Home, Programs, and Notes page

* fix: fix styling to be consistent across pages

* feat: add progress note filtering and add loading spinner to pages

* feat: add account type authorization checks on frontend and backend

* refactor: refactor notes logic and fix styling

* feat: add logic to check for no students and refactor filter

* feat: add shadows using overflow clip

* fix: fix styling for search filter

* fix: fix small style inconsistencies

* fix: update poppins font url to use https

* fix: fix modal close button styling to be more consistent

* fix: fix escape key overriding dialog close

* Squashed commit of the following:

commit 0b133b8
Author: Michael Sullivan <[email protected]>
Date:   Tue May 14 09:09:16 2024 -0700

    Feature/mraysu/program form v2 (#100)

    * Update Backend Program Schema

    * V2 UI

    * Disabled Editing Program Type

    * Frontend-backend integration

    * Lint fixes

    ---------

    Co-authored-by: mraysu <[email protected]>
    Co-authored-by: Adhithya Ananthan <[email protected]>

commit e17b509
Author: parth4apple <[email protected]>
Date:   Tue May 14 09:01:15 2024 -0700

    Student and Enrollment Schema modifications (#101)

    * feat: initial schema

    * feat: edit routes

    * feat: test and fix routes

---------

Co-authored-by: Adhithya Ananthan <[email protected]>
adhi0331 pushed a commit that referenced this pull request Jun 16, 2024
* feat: add create program notes backend

* fix: THead unique key prop warning

* feat: add edited by field to notes

* fix: fix styling issues

* feat: add edit and delete functionality to progress notes and change userId to uid for backend

* fix: fix calendar styling

* feat: add download progress notes functionality using react-pdf

* feat: add mobile responsiveness

* feat: create program context provider shared across Home, Programs, and Notes page

* fix: fix styling to be consistent across pages

* feat: add progress note filtering and add loading spinner to pages

* feat: add account type authorization checks on frontend and backend

* refactor: refactor notes logic and fix styling

* feat: add logic to check for no students and refactor filter

* feat: add shadows using overflow clip

* fix: fix styling for search filter

* fix: fix small style inconsistencies

* fix: update poppins font url to use https

* fix: fix modal close button styling to be more consistent

* fix: fix escape key overriding dialog close

* Squashed commit of the following:

commit 0b133b8
Author: Michael Sullivan <[email protected]>
Date:   Tue May 14 09:09:16 2024 -0700

    Feature/mraysu/program form v2 (#100)

    * Update Backend Program Schema

    * V2 UI

    * Disabled Editing Program Type

    * Frontend-backend integration

    * Lint fixes

    ---------

    Co-authored-by: mraysu <[email protected]>
    Co-authored-by: Adhithya Ananthan <[email protected]>

commit e17b509
Author: parth4apple <[email protected]>
Date:   Tue May 14 09:01:15 2024 -0700

    Student and Enrollment Schema modifications (#101)

    * feat: initial schema

    * feat: edit routes

    * feat: test and fix routes

* feat: add frontend and backend for account archival

* feat: ensure ui updates and refactor code

* Squashed merge with main

* fix: update type of VerifyUser to be same as User

* fix: fix user type error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants