Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/arnav jacob/page footer #15

Merged
merged 31 commits into from
Feb 13, 2024
Merged

Feature/arnav jacob/page footer #15

merged 31 commits into from
Feb 13, 2024

Conversation

jackavh
Copy link
Contributor

@jackavh jackavh commented Feb 2, 2024

Tracking Info

Resolves #4

Changes

Frontend

  • Created the footer and added styling based on figma to files footer.tsx and Footer.module.css
  • Linked to the backend API to provide feedback on newsletter submission: invalid email / duplicate email

Backend

  • Created a schema for subscribers in the mongoDB table
  • Wrote validation chain that normalizes and validates submitted email addresses
  • Performs check to identify duplicate email submissions

Testing

  • Checked that the design of the frontend matches the backend
  • Checked that MongoDB was getting updated with email addresses (for the newsletter)
  • Ran a series of test emails invalid and duplicate to make sure that validation works

Confirmation of Change

Screenshot 2024-01-30 at 4 39 21 PM

Screenshot 2024-01-30 at 4 39 36 PM

Screenshot 2024-01-30 at 4 39 52 PM

Screenshot 2024-01-30 at 4 40 08 PM

Arnav710 and others added 22 commits January 18, 2024 15:57
@Arnav710
create components and style folders
a21a924
@jackavh
Adds icons for the page footer
3681152
@jackavh
Merge branch 'feature/arnav-jacob/page-footer' of https://github.com/…
efe1781 
…TritonSE/4FLOT-Website-Revamp into feature/arnav-jacob/page-footer
@Arnav710
dummy footer
fc29221
@Arnav710
add footer component to page.tsx
bdcfafd
@Arnav710
create footer structure + color
e428bd2
@jackavh
Adds four screens to the page footer
1ac1fc6
@jackavh
adds logo image, facebook and instagram links, and copyright message …
4ce1ad0 
…to footer
@Arnav710
newsletter + links section of footer
418a94a
@jackavh
updates styles on footer.css to look close to figma design
8c99dea
@Arnav710
newsletter section
0603e5b
@jackavh
Merge branch 'main' into feature/arnav-jacob/page-footer
7daf528
@jackavh
imports all fonts and adds checkmark to button, updates some styles
de8b6c1
@jackavh
adds POST /api/subscribers backend route that validates uniqueness fo…
ec23938 
…r emails
@Arnav710
adding the api/subscribers route to the frontend
5716cd4
@Arnav710
fix button logic
deacef8
@jackavh
refactors frontend api routes to be consistent with other branches. s…
20d2200 
…hows error messages in the input box. refactors .css into a .module.css to be consistent with the project
@jackavh
consolidates error messages for the newsletter subscription box
04025b7
@Arnav710
merging main:
51c06ab
@jackavh
changes facebook and instagram icons from png to svg
7ccd1d8
@jackavh
fixes lint check errors for pr
2e3a02c
@jackavh
fixes frontend lint check for pr
efd5dee
@jackavh jackavh marked this pull request as ready for review February 2, 2024 07:57
jennymar
jennymar approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@jennymar jennymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I pushed some code for adding add the Footer component to layout.tsx which will apply automatically the footer to every page inside the app directory, as well as moved some fonts over to globals.css so they can be reused. Great work!

frontend/src/components/footer.tsx Outdated Show resolved Hide resolved
kevindo0720
kevindo0720 reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@kevindo0720 kevindo0720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jackavh jackavh merged commit f5e0fc3 into main Feb 13, 2024
2 checks passed
@jackavh jackavh deleted the feature/arnav-jacob/page-footer branch February 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindo0720 kevindo0720 kevindo0720 approved these changes

@jennymar jennymar jennymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page Footer
4 participants
@jackavh @jennymar @kevindo0720 @Arnav710