Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-8610 SmartOS setup should accept answers.json as a boot module #77

Merged
merged 2 commits into from
Jan 10, 2025
Merged

OS-8610 SmartOS setup should accept answers.json as a boot module #77

merged 2 commits into from
Jan 10, 2025

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Jan 9, 2025

This is pending the 20250109T000743Z release.

@bahamat bahamat requested a review from a team January 9, 2025 17:05
danmcd
danmcd reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about ISO images with answers.json in them...

docs/non-interactive-install.md Show resolved Hide resolved
docs/non-interactive-install.md Outdated Show resolved Hide resolved
danmcd
danmcd approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@bahamat bahamat merged commit 0e4e0ca into master Jan 10, 2025
1 check passed
@bahamat bahamat deleted the add_answers_as_boot_module branch January 16, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahamat @danmcd