add expires option to use ISO 8601 DateTime format string #85
Conversation
|
Why are we breaking existing options? While neither absolute date format is really that appealing we shouldn't break what already exists. I though @jclulow was already working on the form of this that allows relative dates. |
|
@rmustacc I resolved it so it takes either an ISO time string or epoch seconds like before. |
| @@ -119,7 +141,7 @@ function parseOptions() { | |||
| opts.paths.forEach(function (p) { | |||
| var _opts = { | |||
| algorithm: opts.algorithm, | |||
| expires: opts.expires, | |||
| expires: expiresAt, | |||
There was a problem hiding this comment.
Just call validateDate(opts.expires) directly, here.
|
@jclulow all suggestions have been taken and committed. |
|
Hey Carlos, This won't pass lint checks -- please run m |
|
How do I do this on Windows? |
|
None of our development tooling (lint/style/test/build/make) is setup, tested or supported on Windows. You should have a Unix VM somewhere; if not you could always mlogin and validate there for a few minutes. |
changed expires option to use ISO 8601 DateTime format string joyent/node-manta##61