Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taskmanager register shutdown task #1328

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Nov 22, 2024

Fixes #1308

This PR:

  • Adds the ability to register tasks (Callable/Coroutine/Future) to run when a TaskManager is shut down.

Adding these tasks using register_task seems to lead to OS-dependent inconsistencies. So, instead, I added a simple list.

@qstokkink qstokkink force-pushed the add_taskmanager_recursion branch 19 times, most recently from 30cc13b to b0bdd68 Compare November 25, 2024 12:19
@qstokkink qstokkink force-pushed the add_taskmanager_recursion branch from b0bdd68 to df85f37 Compare November 25, 2024 12:22
@qstokkink qstokkink changed the title WIP: Add taskmanager register shutdown task READY: Add taskmanager register shutdown task Nov 25, 2024
@qstokkink qstokkink marked this pull request as ready for review November 25, 2024 12:32
@qstokkink qstokkink changed the title READY: Add taskmanager register shutdown task Add taskmanager register shutdown task Nov 25, 2024
@qstokkink qstokkink merged commit 4a0b2de into Tribler:master Nov 25, 2024
6 checks passed
@qstokkink qstokkink deleted the add_taskmanager_recursion branch November 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow TaskManagers to manage TaskManagers
2 participants