Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update REST tests to use Mocks #1325

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Update REST tests to use Mocks #1325

merged 1 commit into from
Nov 20, 2024

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Nov 20, 2024 •
edited
Loading

Fixes #1305

This PR:

  • Updates the REST tests to use direct endpoint calls and mocks (this is faster*).

*But mostly unnoticable compared to the overhead of GitHub Actions.

@qstokkink qstokkink changed the title WIP: Update REST tests to use Mocks READY: Update REST tests to use Mocks Nov 20, 2024
@qstokkink qstokkink marked this pull request as ready for review November 20, 2024 13:19
@qstokkink qstokkink changed the title READY: Update REST tests to use Mocks Update REST tests to use Mocks Nov 20, 2024
@qstokkink qstokkink merged commit a257bf6 into Tribler:master Nov 20, 2024
6 checks passed
@qstokkink qstokkink deleted the upd_rest_to_mock branch November 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert REST tests to use mocks
2 participants
@qstokkink @egbertbouman