Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shadcn-ui): move shadcn-ui to shadcn #341

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Nov 14, 2024

Fix #309 #340

Move shadcn-ui CLI to shadcn CLI for add components.

Copy link

nx-cloud bot commented Nov 14, 2024

@bzp2010 bzp2010 marked this pull request as draft November 14, 2024 16:38
@bzp2010 bzp2010 marked this pull request as ready for review November 14, 2024 16:52
@bzp2010
Copy link
Contributor Author

bzp2010 commented Nov 14, 2024

About add command:

➜  my-workspaces git:(test) ✗ TS_NODE_PROJECT=tsconfig.base.json pnpm dlx shadcn@latest add sidebar
✔ Checking registry.
✔ Updating packages/shadcn-ui-utils/src/tailwind.config.ts
✔ Updating packages/shadcn-ui-utils/src/global.css
✔ Installing dependencies.
✔ The file sidebar.tsx already exists. Would you like to overwrite? … yes
✔ The file button.tsx already exists. Would you like to overwrite? … yes
✔ The file separator.tsx already exists. Would you like to overwrite? … yes
✔ The file sheet.tsx already exists. Would you like to overwrite? … yes
✔ The file tooltip.tsx already exists. Would you like to overwrite? … yes
✔ The file input.tsx already exists. Would you like to overwrite? … yes
✔ The file use-mobile.tsx already exists. Would you like to overwrite? … yes
✔ The file skeleton.tsx already exists. Would you like to overwrite? … yes
ℹ Updated 8 files:
  - packages/shadcn-ui/src/ui/sidebar.tsx
  - packages/shadcn-ui/src/ui/button.tsx
  - packages/shadcn-ui/src/ui/separator.tsx
  - packages/shadcn-ui/src/ui/sheet.tsx
  - packages/shadcn-ui/src/ui/tooltip.tsx
  - packages/shadcn-ui/src/ui/input.tsx
  - packages/shadcn-ui/src/hooks/use-mobile.tsx
  - packages/shadcn-ui/src/ui/skeleton.tsx

➜  my-workspaces git:(test) ✗ TS_NODE_PROJECT=tsconfig.base.json pnpm dlx shadcn@latest add sidebar --overwrite
✔ Checking registry.
✔ Updating packages/shadcn-ui-utils/src/tailwind.config.ts
✔ Updating packages/shadcn-ui-utils/src/global.css
✔ Installing dependencies.
ℹ Updated 8 files:
  - packages/shadcn-ui/src/ui/sidebar.tsx
  - packages/shadcn-ui/src/ui/button.tsx
  - packages/shadcn-ui/src/ui/separator.tsx
  - packages/shadcn-ui/src/ui/sheet.tsx
  - packages/shadcn-ui/src/ui/tooltip.tsx
  - packages/shadcn-ui/src/ui/input.tsx
  - packages/shadcn-ui/src/hooks/use-mobile.tsx
  - packages/shadcn-ui/src/ui/skeleton.tsx

@bzp2010
Copy link
Contributor Author

bzp2010 commented Nov 15, 2024

I have fixed the timeout issue, please help re-trigger the CI. 🙏

@TriPSs
Copy link
Owner

TriPSs commented Nov 15, 2024

Thanks for the PR! 🎉

@TriPSs TriPSs merged commit df7b2b9 into TriPSs:master Nov 15, 2024
6 checks passed
@bzp2010
Copy link
Contributor Author

bzp2010 commented Nov 15, 2024

Tested with 4.2.0 in a project and add-component works fine. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running nx run ui-lib:add-component .... due to 'shadcn-ui' not being recognized
2 participants