-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strapi #178
Conversation
…cted for yarn projects
BREAKING CHANGE: The build implementation changed causing the `src/admin/webpack.config.js` to be updated with `withNx`. See [webpack.config.js.template](./packages/strapi/src/generators/init/files/src/admin/webpack.config.js.template). Also the `tsConfig` option is now required.
@joshuaellis would you be willing to check the Strapi implementation? It consists of these two files: nx-extend/packages/strapi/src/executors/build/build.impl.ts Lines 24 to 81 in b8352d0
And an 'use strict'
const { withNx } = require('@nx-extend/strapi')
module.exports = (config, webpack) => {
return withNx(config, webpack)
} nx-extend/packages/strapi/src/with-nx.ts Lines 1 to 48 in b8352d0
|
Directly trying to finally get the E2E test to run inside the CI 😅 |
For these bits: config.entry.main = [workspaceRoot + `/${root}/.strapi/client/app.js`]
config.output.path = workspaceRoot + `/${outputPath}/build` you might be better off trying to utilise the existing paths and see if you can mutate them into what you want, but i think that would be a nice to have :) |
@joshuaellis good one, thanks! |
No description provided.