Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue making it impossible to use stack references #162

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Sep 30, 2023

Turns out putting the stack reference function in index.ts was a bad idea. Now, when importing it, the full Pulumi instructions from that project get included in the parent project as well. Really bad.

This splits it out in a separate file. Do you think it looks OK? Not sure if this is how to do it.

@nx-cloud
Copy link

nx-cloud bot commented Sep 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e3feae8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ffMathy ffMathy changed the title Update index.ts.template fix: issue making it impossible to use stack references Sep 30, 2023
@ffMathy ffMathy marked this pull request as ready for review September 30, 2023 18:23
@TriPSs TriPSs merged commit 13f3b71 into TriPSs:master Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants