Skip to content

Commit

Permalink
docs(shadcn-ui): Update README to correct nx command syntax (#336)
Browse files Browse the repository at this point in the history
Fixes #334
  • Loading branch information
TriPSs authored Nov 6, 2024
2 parents 1dca64c + c78d4e0 commit 81646ef
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 11 deletions.
19 changes: 11 additions & 8 deletions packages/e2e-runner/src/executors/run/run.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export interface RunOptions {
runner: 'cypress' | 'playwright' | '@nx/playwright' | 'run-commands'
runnerTarget?: string
watch?: boolean
skipTargets?: boolean
targets: NxTargetOptions[]
}

Expand All @@ -21,18 +22,20 @@ export async function endToEndRunner(
options: RunOptions,
context: ExecutorContext
): Promise<{ success: boolean }> {
const { runner, targets, ...rest } = options
const { runner, targets, skipTargets, ...rest } = options

runningTargets = targets.map((targetOptions) => new NxTarget(targetOptions))
if (!skipTargets) {
runningTargets = targets.map((targetOptions) => new NxTarget(targetOptions))

try {
// Start all targets
await Promise.all(runningTargets.map((nxTarget) => nxTarget.setup()))
try {
// Start all targets
await Promise.all(runningTargets.map((nxTarget) => nxTarget.setup()))

} catch {
await killTargets()
} catch {
await killTargets()

return { success: false }
return { success: false }
}
}

try {
Expand Down
8 changes: 7 additions & 1 deletion packages/e2e-runner/src/executors/run/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
"title": "Build executor",
"description": "",
"type": "object",
"properties": {},
"properties": {
"skipTargets": {
"type": "boolean",
"description": "When `true` the provided targets will be skipped.",
"default": false
}
},
"required": []
}
4 changes: 2 additions & 2 deletions packages/shadcn-ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ export const links: LinksFunction = () => [
### Add

```sh
nx add <ui lib name> button
nx add-component <ui lib name> button
```

### All all components

```sh
nx add <ui lib name>
nx add-component <ui lib name>
```

## Updating the theme
Expand Down

0 comments on commit 81646ef

Please sign in to comment.