+ add support for ingress option (#185)

Hi there, needed this option included, so please let me know if this can be merged, would be cool. thanks
TriPSs · Dec 1, 2023 · 4ba0f0a · 4ba0f0a
2 parents 9b219f2 + 17f3743
commit 4ba0f0a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/gcp-cloud-run/src/executors/deploy/deploy.impl.ts b/packages/gcp-cloud-run/src/executors/deploy/deploy.impl.ts
@@ -43,7 +43,8 @@ export function deployExecutor(
     timeout = null,
 
     cpu,
-    cpuBoost
+    cpuBoost,
+    ingress
   } = options
 
   const distDirectory = join(context.root, outputDirectory)
@@ -112,6 +113,14 @@ export function deployExecutor(
     })
     .filter(Boolean)
 
+  const ingressOpts = ["all", "internal", "internal-and-cloud-load-balancing"];
+  const validIngress = (typeof ingress === "string") && ingressOpts.includes(ingress);
+  if (!validIngress) {
+      logger.warn(
+        `"${ingress}" is not a valid ingress option! Only the following few options are supported: ${ingressOpts}`
+      )
+  }
+
   if (generateRepoInfoFile) {
     logger.info('Generating repo info file')
 
@@ -155,7 +164,9 @@ export function deployExecutor(
     typeof cpuBoost === 'boolean' && !cpuBoost && '--no-cpu-boost',
 
     // There can be a question if a repo should be created
-    buildWithArtifactRegistry && autoCreateArtifactsRepo && '--quiet'
+    buildWithArtifactRegistry && autoCreateArtifactsRepo && '--quiet',
+
+    validIngress && `--ingress=${ingress}`
   ])
 
   return Promise.resolve(

diff --git a/packages/gcp-cloud-run/src/executors/schema.d.ts b/packages/gcp-cloud-run/src/executors/schema.d.ts
@@ -27,4 +27,5 @@ export interface ExecutorSchema {
   timeout?: number
   cpu?: number
   cpuBoost?: boolean
+  ingress?: string
 }