Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for custom root in config on dashboard index #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tao-Galasse
Copy link
Contributor

@Tao-Galasse Tao-Galasse commented May 11, 2021

Hello @spohlenz !

Here is a little POC to fix a recent issue which I think should be improved. It's probably not the cleanest way to do it, but I wanted to provide an example of how we could find a solution.

Currently, Trestle do not use the value set in config.root as the default redirected route of the application.

For example, if you defined a root which is not the one with the highest priority, it will be used as the "home" in the breadcrumb, but will not be the view displayed when accessing the base URL of the back office.

IMHO, those two values should be the same, what is defined as the "root" should be the default view.

Do you have any opinion about this ?

@coveralls
Copy link

coveralls commented May 11, 2021

Coverage Status

Coverage decreased (-0.03%) to 90.964% when pulling 94c7a46 on Tao-Galasse:dashboard-index-root into 31cac2e on TrestleAdmin:master.

@Tao-Galasse Tao-Galasse force-pushed the dashboard-index-root branch from 3808ef8 to 4030f7c Compare May 11, 2021 16:44
@Tao-Galasse Tao-Galasse force-pushed the dashboard-index-root branch from 4030f7c to 94c7a46 Compare May 11, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants