Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 6 #9

Merged
merged 15 commits into from
Apr 18, 2024
Merged

Task 6 #9

merged 15 commits into from
Apr 18, 2024

Conversation

TreshMom
Copy link
Owner

Диффы по 3/4 таксу и 6 тут, пока в 6 16 тестов из 66 не проходят

@TreshMom
Copy link
Owner Author

Сделал!

@TreshMom TreshMom requested a review from WoWaster April 10, 2024 20:07
Copy link

@WoWaster WoWaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вы же поправили 4 задачку. Подтяните её сюда, чтобы не удалять файлик с тестами...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кхм, ну не надо удалять наши файлики :(

@TreshMom
Copy link
Owner Author

TreshMom commented Apr 17, 2024

С точки зрения тестов - все ок. Я залил 4 таск в main и возник конфликт, я его разрешил, но только вот забыл про pre-commit и black)
Теперь все ок.

@TreshMom
Copy link
Owner Author

первый фулл балл за дз, это победа.
Но в диффах снова какой-то треш...

Copy link

@WoWaster WoWaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я сделаю вид, что весь этот треш я не наблюдаю и смотрю только на тестики...

@TreshMom TreshMom changed the base branch from main to task-7 April 18, 2024 12:02
@TreshMom TreshMom merged commit 791706b into task-7 Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants