(http): assume the provided paths are encoded and pass them as is

Trendyol · Apr 22, 2024 · d4e4f90 · d4e4f90
1 parent 9123a05
commit d4e4f90
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/stove-testing-e2e-http/src/main/kotlin/com/trendyol/stove/testing/e2e/http/HttpSystem.kt b/lib/stove-testing-e2e-http/src/main/kotlin/com/trendyol/stove/testing/e2e/http/HttpSystem.kt
@@ -221,7 +221,8 @@ class HttpSystem(
     }
 
     @PublishedApi
-    internal fun relative(uri: String): Url = URLBuilder(testSystem.baseUrl).apply { path(uri) }.build()
+    internal fun relative(uri: String): Url = URLBuilder(testSystem.baseUrl)
+        .apply { appendEncodedPathSegments(uri) }.build()
 
     @PublishedApi
     internal fun toFormData(

diff --git a/...e-testing-e2e-http/src/test/kotlin/com/trendyol/stove/testing/e2e/http/HttpSystemTests.kt b/...e-testing-e2e-http/src/test/kotlin/com/trendyol/stove/testing/e2e/http/HttpSystemTests.kt
@@ -258,6 +258,21 @@ class HttpSystemTests : FunSpec({
             }
         }
     }
+
+    test("keep path segments as is") {
+        val expectedGetDtoName = UUID.randomUUID().toString()
+        TestSystem.validate {
+            wiremock {
+                mockGet("/get?path=1", 200, responseBody = TestDto(expectedGetDtoName).some())
+            }
+
+            http {
+                get<TestDto>("/get?path=1") { actual ->
+                    actual.name shouldBe expectedGetDtoName
+                }
+            }
+        }
+    }
 })
 
 data class TestDto(