Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade golang version v1.20 #73

Merged
merged 4 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ jobs:
fetch-depth: 0

- name: Set up Go
uses: actions/setup-go@v3
uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.50
version: v1.52.2
args: -c .golangci.yml --timeout=5m -v

- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
- run: git tag ${{ github.event.inputs.tag }}

- name: Set up Go
uses: actions/setup-go@v3
uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: '1.20'

- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.19
go-version: '1.20'

- uses: actions/checkout@v3
- name: Start containers
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ linters:
- whitespace

service:
golangci-lint-version: 1.50.x # use the fixed version to not introduce new linters unexpectedly
golangci-lint-version: 1.52.2 # use the fixed version to not introduce new linters unexpectedly
prepare:
- echo "here I can run custom commands, but no preparation needed for this repo"
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.20-alpine as builder

WORKDIR /project

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ default: init

init:
go mod download
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2
go install golang.org/x/tools/go/analysis/passes/fieldalignment/cmd/fieldalignment@latest

clean:
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ The benchmark was made with the **1,001,006** Couchbase document, because it is
difference in the batch structure between the two packages. **Default configurations** for Java Kafka Connect Couchbase
used for both connectors.

| Package | Time to Process Events | Average CPU Usage(Core) | Average Memory Usage |
|:-------------------------------------|:----------------------:|:-----------------------:|:--------------------:|
| **Go Dcp Kafka**(1.19) | **12s** | **0.383** | **428MB**
| Java Kafka Connect Couchbase(JDK11) | 19s | 1.5 | 932MB
| Package | Time to Process Events | Average CPU Usage(Core) | Average Memory Usage |
|:------------------------------------|:----------------------:|:-----------------------:|:--------------------:|
| **Go Dcp Kafka**(1.20) | **12s** | **0.383** | **428MB**
| Java Kafka Connect Couchbase(JDK11) | 19s | 1.5 | 932MB

## Example

Expand Down
2 changes: 1 addition & 1 deletion example/default-mapper/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.20-alpine as builder

WORKDIR /project

Expand Down
2 changes: 1 addition & 1 deletion example/default-mapper/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module example

go 1.19
go 1.20

replace github.com/Trendyol/go-dcp-kafka => ./../..

Expand Down
2 changes: 1 addition & 1 deletion example/simple-logger/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.20-alpine as builder

WORKDIR /project

Expand Down
2 changes: 1 addition & 1 deletion example/simple-logger/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module example

go 1.19
go 1.20

replace github.com/Trendyol/go-dcp-kafka => ./../..

Expand Down
2 changes: 1 addition & 1 deletion example/simple/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.20-alpine as builder

WORKDIR /project

Expand Down
2 changes: 1 addition & 1 deletion example/simple/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module example

go 1.19
go 1.20

replace github.com/Trendyol/go-dcp-kafka => ./../..

Expand Down
2 changes: 1 addition & 1 deletion example/struct-config/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.20-alpine as builder

WORKDIR /project

Expand Down
2 changes: 1 addition & 1 deletion example/struct-config/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module example

go 1.19
go 1.20

replace github.com/Trendyol/go-dcp-kafka => ./../..

Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/Trendyol/go-dcp-kafka

go 1.19
go 1.20

require (
github.com/Trendyol/go-dcp v1.1.13
Expand Down
2 changes: 1 addition & 1 deletion test/integration/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.20-alpine as builder

WORKDIR /project

Expand Down
2 changes: 1 addition & 1 deletion test/integration/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module integration-test-example

go 1.19
go 1.20

replace github.com/Trendyol/go-dcp-kafka => ../../.

Expand Down