Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AMD SKINIT to slaunch #17

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

SergiiDmytruk
Copy link
Member

This addresses TrenchBoot/trenchboot-issues#21 and #11.

SKL haven't been updated, so this can't be tested yet.

grub-core/loader/multiboot_mbi2.c Outdated Show resolved Hide resolved
grub-core/loader/i386/slaunch.c Show resolved Hide resolved
grub-core/loader/i386/skinit.c Outdated Show resolved Hide resolved
Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Sergii Dmytruk <[email protected]>
Copy link
Member

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more problems discovered after starting on hardware. Still doesn't work after fixing them, but the rest of the problems is in SKL, I think.

grub-core/loader/i386/slaunch.c Outdated Show resolved Hide resolved
grub-core/loader/multiboot_mbi2.c Show resolved Hide resolved
krystian-hebel and others added 3 commits February 28, 2024 00:26
This updates `struct grub_slr_entry_dl_info`:
 * by adding `dlme_base` and `dlme_size` which weren't necessary for
   Intel TXT because the same information is passed via OS2SINIT data
 * by changing `dlme_entry` from `grub_uint64_t` to `grub_uint32_t`
   because that should be enough for an offset

Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Sergii Dmytruk <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Sergii Dmytruk <[email protected]>
Update `slaunch_module` global only if new module passed all checks.

Closes #11.

Signed-off-by: Sergii Dmytruk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants