Add string_content node for easier querying
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also made `:` in a colon string to be its own anonymous node. However, this comes with a side-effect of a singular `:` being detected as `(string)` with missing `(string_content)`, but it doesn't matter since the only place a single `:` is used is a binding, which overrides `(string)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made colon in a colon string to be its own anonymous node, and added
(string_content)which captures just the string's content, without the colon or quotes, making it easier to query::my-string --- (string ":" (string_content))Important
There is an unpleasant side-effect of a single colon
:being detected as a string with missing string_content. This is not a big issue, since the only place a single colon is used is in a binding, which itself overrides(string). A more elegant solution would be an external parser, but that's too much for such a small issue.