Common.credentials synchronicity issues. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2014 12:56
Also added afterEach for tests that needed to ensure an undefined shared object
…k the functionality down to integration level (as far as we can go before sending request out to backend)
Updated both view files to use UNIX line endings instead of DOS Sometimes Common.credentials is an object and sometimes a string. I updated a few location shwere this was causing a problem but this is simply a band-aid for now. The overall design of this feature needs to be re-worked to be reliable and consistent. So this partially fixes issues #139.
Fixed synchronicity issues with sessionStorage and Common.cache Removed band-aid that ensured Common.credentials was properly handled as string and object in favor of proper logic enforcing the use of an object
lifeBCE
changed the title
Updated cloudSetupView.js to default to id if selectedId is not populated
…OC anyway) Need to mock up Common.account object for use by all tests
… access application.
Fixes issues #147
Model unit tests
Default selectedId to id when selectedId is not populated
Updated both view files to use UNIX line endings instead of DOS Sometimes Common.credentials is an object and sometimes a string. I updated a few location shwere this was causing a problem but this is simply a band-aid for now. The overall design of this feature needs to be re-worked to be reliable and consistent. So this partially fixes issues #139.
Fixed synchronicity issues with sessionStorage and Common.cache Removed band-aid that ensured Common.credentials was properly handled as string and object in favor of proper logic enforcing the use of an object
…_139 Conflicts: js/collections/cloudCredentials.js js/views/account/cloudCredentialManagementListView.js
huxoll
added a commit
that referenced
this pull request
Jun 17, 2014
Common.credentials synchronicity issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #139 #142
Updated some spacing and indentions (mixed tabs and spaces)
Updated both view files to use UNIX line endings instead of DOS
Fixed all issues with Common.credentials type
Fixed synchronicity issues with sessionStorage and Common.cache