Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common.credentials confusion #142

Open
lifeBCE opened this issue Jun 11, 2014 · 1 comment
Open

Common.credentials confusion #142

lifeBCE opened this issue Jun 11, 2014 · 1 comment

Comments

@lifeBCE
Copy link

lifeBCE commented Jun 11, 2014

Sometimes Common.credentials is an object and sometimes a string. All supporting logic seems to depend on this being an object so we need to rework this to ensure it is always an object. The setter defined in common.js shows:

Common.cacheCollection.account.cloud_credentials = JSON.stringify(val);

So every time the application does:

Common.credentials = data.account.cloud_credentials;

We get a string assigned.

If we want to keep this as a string representation of an object, we need to update all supporting logic to call JSON.parse before attempting to iterate.

@lifeBCE
Copy link
Author

lifeBCE commented Jun 11, 2014

related to issue #139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant