Fix bug where actions rarely get timed out on rejoin #1569
Conversation
Fix case when an action is scheduled, then disconnected, then sits in an idle stat until it is considered timed out, then it gets joined onto another client, the matching engine logic will mark it timed out before the client is able to mark it keep_alive. closes: TraceMachina#1568
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 3 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / lre-cc / ubuntu-24.04, Local / lre-rs / macos-14, Local / lre-rs / ubuntu-24.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / lre-cc / large-ubuntu-22.04, Remote / lre-rs / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @aaronmondal)
Fix case when an action is scheduled, then disconnected, then sits in an idle stat until it is considered
timed out, then it gets joined onto another client, the matching engine logic will mark it timed out before the client is able to mark it keep_alive.
closes: #1568
This change is