Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): prevent injection during jinja templating (v2.23) #1849

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

davinov
Copy link
Member

@davinov davinov commented Dec 11, 2024

Security issue: some users could inject malicious code in jinja templates in queries if we don't use the sandboxed environment

@davinov davinov added Need Review sec python Pull requests that update Python code labels Dec 11, 2024
@davinov davinov changed the title fix(common): prevent injection during jinja templating fix(common): prevent injection during jinja templating (v2.23) Dec 11, 2024
@davinov davinov changed the base branch from release/v3.23 to master December 11, 2024 17:58
@davinov davinov requested a review from a team as a code owner December 11, 2024 17:58
@davinov davinov requested review from fspot and Fanaen December 11, 2024 17:58
@davinov davinov changed the base branch from master to release/v3.23 December 11, 2024 17:59
Copy link
Contributor

@lukapeschke lukapeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davinov davinov merged commit b5de1f3 into release/v3.23 Dec 12, 2024
2 checks passed
@davinov davinov deleted the fix-jinja-injection branch December 12, 2024 09:04
@davinov davinov restored the fix-jinja-injection branch December 12, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need Review python Pull requests that update Python code sec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants