-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lts): oracle install script #1453
Conversation
unzip /tmp/oracle_client_lib.zip -d /opt/oracle | ||
sh -c "echo /opt/oracle/instantclient_12_2 > /etc/ld.so.conf.d/oracle-instantclient.conf" | ||
ldconfig | ||
rm -rf /tmp/gdown.pl /tmp/oracle_client_lib.zip | ||
rm -rf /tmp/oracle_client_lib.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm -rf /tmp/oracle_client_lib.zip | |
rm -f /tmp/oracle_client_lib.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonne remarque
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'aurais aussi mis le lien vers l'url et certains paths dans des envs vars pour que ce soit facilement modifiables apres si jamais ceux ci changent... sinon, LGTM 🦾
* fix: oracle install script * chore: review
Fix oracle install script by replacing gdown.pl with wget and fixing the archive hosted on our cloud