Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lts): oracle install script #1453

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix(lts): oracle install script #1453

merged 2 commits into from
Jan 16, 2024

Conversation

fspot
Copy link
Member

@fspot fspot commented Jan 16, 2024

Fix oracle install script by replacing gdown.pl with wget and fixing the archive hosted on our cloud

@fspot fspot added the bug Something isn't working label Jan 16, 2024
@fspot fspot self-assigned this Jan 16, 2024
unzip /tmp/oracle_client_lib.zip -d /opt/oracle
sh -c "echo /opt/oracle/instantclient_12_2 > /etc/ld.so.conf.d/oracle-instantclient.conf"
ldconfig
rm -rf /tmp/gdown.pl /tmp/oracle_client_lib.zip
rm -rf /tmp/oracle_client_lib.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm -rf /tmp/oracle_client_lib.zip
rm -f /tmp/oracle_client_lib.zip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonne remarque

Copy link
Contributor

@Sanix-Darker Sanix-Darker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aurais aussi mis le lien vers l'url et certains paths dans des envs vars pour que ce soit facilement modifiables apres si jamais ceux ci changent... sinon, LGTM 🦾

@fspot fspot merged commit d73b534 into release/v3.23 Jan 16, 2024
2 checks passed
@fspot fspot deleted the release/3.23.24 branch January 16, 2024 13:41
lukapeschke pushed a commit that referenced this pull request Jan 18, 2024
* fix: oracle install script

* chore: review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants