fix: get good project_id from jwt or google-creds when they are set or not [TCTC-6942] #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanix-Darker
force-pushed
the
fix/gbq-configuration
branch
from
f4f4d45 to
e4453a2
Compare
…_credentials or the google-credentials doc: update the CHANGELOG.md
Sanix-Darker
force-pushed
the
fix/gbq-configuration
branch
from
e4453a2 to
c917f0d
Compare
Sanix-Darker
force-pushed
the
fix/gbq-configuration
branch
from
76c189f to
398f6ef
Compare
Sanix-Darker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
get the "good" and "valid" project-id from the connector configuration
WHY
When both JWT and GoogleCreds were sets, on the "configuration for listing tables and schemas", we were using the wrong project-id to make requests, now, we make sure the jwt-credentials is checkec but also contains all informations needed.
HOW
ADDITIONAL INFOS
this branch is deployed on the ange guru and can be tested on the app TCTC-6942