Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: atemp to bump pydantic v2 #1172

Closed
wants to merge 8 commits into from
Closed

chore: atemp to bump pydantic v2 #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7727eab
chore: atemp to bump pydantic v2
Sanix-Darker Jul 12, 2023
1605c5e
ci: let's test the CI
Sanix-Darker Jul 12, 2023
5f60474
feat: update to run tests
Sanix-Darker Jul 12, 2023
2d296ed
feat: migration code for pydanticv2 support + lint
Sanix-Darker Jul 12, 2023
48ddd0d
more update for the migration
Sanix-Darker Jul 12, 2023
cb06e4c
wip
Sanix-Darker Jul 13, 2023
5d0b2d5
no lint error for pydantic 2
Sanix-Darker Jul 13, 2023
a7a0f38
Merge branch 'master' into chore/bump-pydantic-v2
Sanix-Darker Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
name: CI

on:
# Trigger analysis when pushing in master or pull requests, and when creating
# a pull request.
push:
branches:
- master
pull_request:
types: [opened, synchronize, reopened]
# temporary just to see what happens with the CI
on: [push]

jobs:
run:
Expand All @@ -16,6 +10,7 @@ jobs:
fail-fast: false
matrix:
python-version: ['3.10', '3.11']
pydantic-version: ['^1.10', '^2.0']

steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -50,6 +45,15 @@ jobs:
- name: Install odbc dependencies
run: sudo bash toucan_connectors/install_scripts/odbc.sh

- name: Update Pydantic version on the toml & lock
run: |
pip install -U pip poetry
# we update the pydantic version corresponding to the matrix
sed -i "s/pydantic = \".*\"/pydantic = \"${PYDANTIC_VERSION}\"/" pyproject.toml
poetry lock --no-update
env:
PYDANTIC_VERSION: ${{ matrix.pydantic-version }}

- name: install
run: make install

Expand Down
102 changes: 55 additions & 47 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading