Skip to content

Commit

Permalink
fix: some typos on .md and in comments
Browse files Browse the repository at this point in the history
doc: updaete on the doc
doc: add those details to the CHANGELOG
  • Loading branch information
Sanix-Darker committed Sep 21, 2023
1 parent d9a27bf commit 40fc86e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

## Unreleased

## Fixed

- Goole Big Query:
- fix Validation error when all GoogleCredentials are not set (only the `project_id` is required).
- Explicit error information when no data to return.
- fallback on normal GoogleCredentials connexion mode when jwt-token is not valid aymore.

### [4.9.0] 2023-09-20

## Changed
Expand Down
4 changes: 2 additions & 2 deletions doc/connectors/google_big_query.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ For authentication, download an authentication file from console.developper.com
and use the values here. This is an oauth2 credential file. For more information
see this: http://gspread.readthedocs.io/en/latest/oauth2.html

* `type`: str
* `project_id`: str
* `type`: str, required
* `project_id`: str, required
* `private_key_id`: str
* `private_key`: str
* `client_email`: str
Expand Down
2 changes: 1 addition & 1 deletion tests/google_big_query/test_google_big_query.py
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ def test_optional_fields_validator_for_google_creds():
incomplete_credentials_with_no_project_id = {
'type': 'service_account',
}
# should raise an errro if the project_id is not set
# should raise an error if the project_id is not set
with pytest.raises(ValidationError) as _:
_ = GoogleBigQueryConnector(
name='something', credentials=incomplete_credentials_with_no_project_id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def _bigquery_variable_transformer(variable: str):
"""Add surrounding for parameters injection"""
return f'@{variable}'

def _bigquery_client_with_google_creds(self):
def _bigquery_client_with_google_creds(self) -> bigquery.Client:
try:
credentials = GoogleBigQueryConnector._get_google_credentials(
self.credentials, self.scopes
Expand Down

0 comments on commit 40fc86e

Please sign in to comment.