Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cast bools to strings if mixed types #251

Merged
merged 3 commits into from
Jul 19, 2024
Merged

feat: cast bools to strings if mixed types #251

merged 3 commits into from
Jul 19, 2024

Conversation

PrettyWood
Copy link
Member

fix #250

@PrettyWood PrettyWood force-pushed the bool-string branch 2 times, most recently from 82e3e2a to e580741 Compare July 17, 2024 13:02
@PrettyWood PrettyWood requested a review from lukapeschke July 17, 2024 13:05
@PrettyWood PrettyWood self-assigned this Jul 17, 2024
@PrettyWood PrettyWood added enhancement New feature or request 🦀 rust 🦀 Pull requests that edit Rust code ✋ need review ✋ labels Jul 17, 2024
lukapeschke
lukapeschke reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@lukapeschke lukapeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks neat, thanks 👌

For the tests, there's a fixture-multi-dtypes-columns.xlsx sheet, and a test_dtypes.py file, maybe these would be a better place to put the test and the fixture column ?

@PrettyWood PrettyWood merged commit 415ae26 into main Jul 19, 2024
22 checks passed
@PrettyWood PrettyWood deleted the bool-string branch July 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukapeschke lukapeschke lukapeschke approved these changes

Assignees

@PrettyWood PrettyWood

Labels
🦀 rust 🦀 Pull requests that edit Rust code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When coercing columns to strings, boolean cells turn into null
2 participants
@PrettyWood @lukapeschke