Merge pull request #697 from TotallyNotRobots/remove-noinspection

refactor: remove old noinspection comments from PyCharm

cloudbot/__main__.py

@@ -34,7 +34,6 @@ async def async_main():
     # define closure for signal handling
     # The handler is called with two arguments: the signal number and the current stack frame
     # These parameters should NOT be removed
-    # noinspection PyUnusedLocal
     def exit_gracefully(signum, frame):
         nonlocal stopped_while_restarting
         if not _bot:

cloudbot/event.py

@@ -294,7 +294,6 @@ def ctcp(self, message, ctcp_type, target=None):
         if not hasattr(self.conn, "ctcp"):
             raise ValueError("CTCP can only be used on IRC connections")
 
-        # noinspection PyUnresolvedReferences
         self.conn.ctcp(target, ctcp_type, message)
 
     def notice(self, message, target=None):

cloudbot/util/http.py

@@ -134,7 +134,6 @@ def open_request(
     return opener.open(request)
 
 
-# noinspection PyShadowingBuiltins
 def open(
     url,
     query_params=None,

plugins/core/core_sieve.py

@@ -20,7 +20,6 @@ def task_clear():
             del buckets[uid]
 
 
-# noinspection PyUnusedLocal
 @hook.sieve()
 def check_acls(bot: CloudBot, event: Event, _hook: Hook) -> Optional[Event]:
     """
@@ -50,7 +49,6 @@ def check_acls(bot: CloudBot, event: Event, _hook: Hook) -> Optional[Event]:
     return event
 
 
-# noinspection PyUnusedLocal
 @hook.sieve()
 async def perm_sieve(
     bot: CloudBot, event: Event, _hook: Hook
@@ -71,7 +69,6 @@ async def perm_sieve(
     return event
 
 
-# noinspection PyUnusedLocal
 @hook.sieve()
 def check_disabled(
     bot: CloudBot, event: CommandEvent, _hook: Hook
@@ -88,7 +85,6 @@ def check_disabled(
     return event
 
 
-# noinspection PyUnusedLocal
 @hook.sieve()
 def rate_limit(bot: CloudBot, event: Event, _hook: Hook) -> Optional[Event]:
     """

plugins/core/ignore.py

@@ -106,7 +106,6 @@ def is_ignored(conn, chan, mask):
     return False
 
 
-# noinspection PyUnusedLocal
 @hook.sieve(priority=50)
 async def ignore_sieve(bot, event, _hook):
     # don't block event hooks

plugins/core/optout.py

@@ -187,7 +187,6 @@ def load_cache(db):
         optout_cache.update(new_cache)
 
 
-# noinspection PyUnusedLocal
 @hook.sieve(priority=Priority.HIGHEST)
 def optout_sieve(bot, event, _hook):
     if not event.chan or not event.conn:

plugins/cryptocurrency.py

@@ -105,7 +105,6 @@ def __new__(cls, name, bases, members):
 
 
 class Schema(metaclass=SchemaMeta):
-    # noinspection PyUnusedName
     _abstract = True
     _fields = ()
 
@@ -149,7 +148,6 @@ def __init__(self, status: ResponseStatus, data: Any = None):
 
 
 class Platform(Schema):
-    # noinspection PyShadowingBuiltins
     def __init__(
         self, id: int, name: str, symbol: str, slug: str, token_address: str
     ):
@@ -193,7 +191,6 @@ def __init__(
 
 
 class CryptoCurrency(Schema):
-    # noinspection PyShadowingBuiltins
     def __init__(
         self,
         id: int,
@@ -237,7 +234,6 @@ def __init__(self, data: Dict[str, CryptoCurrency], status: ResponseStatus):
 
 
 class FiatCurrency(Schema):
-    # noinspection PyShadowingBuiltins
     def __init__(self, id: int, name: str, sign: str, symbol: str):
         super().__init__()
         self.id = id
@@ -257,7 +253,6 @@ def __init__(self, data: List[FiatCurrency], status: ResponseStatus):
 
 
 class CryptoCurrencyEntry(Schema):
-    # noinspection PyShadowingBuiltins
     def __init__(
         self,
         id: int,

plugins/gnomeagainsthumanity.py

@@ -26,7 +26,6 @@ def CAHblackcard(text):
     """<text> - Submit text with _ for the bot to fill in the rest. You can submit text with multiple _"""
     CardText = text.strip()
 
-    # noinspection PyUnusedLocal
     def blankfiller(matchobj):
         return random.choice(gnomecards["white"])
 

plugins/profiling.py

@@ -127,7 +127,6 @@ def pympler_diff():
 if os.name == "posix":
     # The handler is called with two arguments: the signal number and the current stack frame
     # These parameters should NOT be removed
-    # noinspection PyUnusedLocal
     def debug(sig, frame):
         print(get_thread_dump())
 

tests/core_tests/irc_client_test.py

@@ -461,7 +461,6 @@ async def test_exc(self, caplog_bot, event_loop):
         client = await self.make_client(event_loop)
         runs = 0
 
-        # noinspection PyUnusedLocal
         async def connect(timeout):
             nonlocal runs
             if runs == 5:
@@ -524,7 +523,6 @@ async def test_timeout_exc(self, caplog_bot, event_loop):
         client = await self.make_client(event_loop)
         runs = 0
 
-        # noinspection PyUnusedLocal
         async def connect(timeout):
             nonlocal runs
             if runs == 5:

tests/core_tests/util_tests/test_formatting.py

@@ -141,7 +141,6 @@ def test_truncate_str():
     )
 
 
-# noinspection PyPep8
 def test_truncate_words():
     assert (
         truncate_words(

tests/core_tests/util_tests/test_tokenbucket.py

@@ -6,7 +6,6 @@
 from cloudbot.util import tokenbucket
 
 
-# noinspection PyProtectedMember
 def test_bucket_consume():
     bucket = tokenbucket.TokenBucket(10, 5)
     # larger then capacity
@@ -19,7 +18,6 @@ def test_bucket_consume():
     assert bucket.consume(10) is False
 
 
-# noinspection PyProtectedMember
 def test_bucket_advanced():
     bucket = tokenbucket.TokenBucket(10, 1)
     # tokens start at 10

tests/plugin_tests/core_sieve_test.py

@@ -8,7 +8,6 @@
 from plugins.core import core_sieve
 
 
-# noinspection PyUnusedFunction
 @pytest.fixture(autouse=True)
 def reset_buckets() -> Iterator[None]:
     """