Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial operators - improve documentation #1960

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Oct 18, 2024

Changes

Improves the documentation for IdentityOperator, MatrixOperator and ZeroOperator.

image
image
image

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

Closes #1950

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
    [ ] I have implemented unit tests that cover any new or modified functionality
    [ ] CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

--->

@MargaretDuff MargaretDuff linked an issue Oct 18, 2024 that may be closed by this pull request
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement but I had extra ideas/query

Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates!

@hrobarts
Copy link
Contributor

Hi Margaret, these sound like good changes. I just checked the docs from the latest GHA build for this PR - is this rendering as you expect? I looked in the v24.2.0 and nightly folders, not sure if that's the right place.
image

@MargaretDuff
Copy link
Member Author

Hi Margaret, these sound like good changes. I just checked the docs from the latest GHA build for this PR - is this rendering as you expect? I looked in the v24.2.0 and nightly folders, not sure if that's the right place. image

Thanks Hannah! Did you look in the "1960_merge" folder?

@hrobarts
Copy link
Contributor

hrobarts commented Oct 21, 2024

Thanks Hannah! Did you look in the "1960_merge" folder?

Ahh sorry, I knew I was missing something 🤦‍♀️ Yes I can see the changes in the merge folder

@MargaretDuff
Copy link
Member Author

Thanks Hannah! Did you look in the "1960_merge" folder?

Ahh sorry, I knew I was missing something 🤦‍♀️ Yes I can see the changes in the merge folder

Thanks Hannah - let me know if it looks ok or if you spot any typos

@hrobarts
Copy link
Contributor

Thanks Hannah! Did you look in the "1960_merge" folder?

Ahh sorry, I knew I was missing something 🤦‍♀️ Yes I can see the changes in the merge folder

Thanks Hannah - let me know if it looks ok or if you spot any typos

Looks good to me. Just a question really, do we want to have the same thing in the function description and return? I would either make the description more wordy like "Computes the adjoint of the identity operator Id*(x) = x" or remove the description if the return is sufficient.

image

@MargaretDuff
Copy link
Member Author

Thanks @hrobarts - I have tried to add more/different information to the docstring

Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new additions look great

Copy link
Contributor

@hrobarts hrobarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MargaretDuff looking good

@MargaretDuff MargaretDuff merged commit 23187c9 into TomographicImaging:master Oct 22, 2024
10 checks passed
@MargaretDuff MargaretDuff deleted the trivial-operators-documentation branch October 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trivial operators - improve documentation
3 participants