-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivial operators - improve documentation #1960
Trivial operators - improve documentation #1960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement but I had extra ideas/query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates!
Ahh sorry, I knew I was missing something 🤦♀️ Yes I can see the changes in the merge folder |
Thanks Hannah - let me know if it looks ok or if you spot any typos |
Looks good to me. Just a question really, do we want to have the same thing in the function description and return? I would either make the description more wordy like "Computes the adjoint of the identity operator Id*(x) = x" or remove the description if the return is sufficient. |
Thanks @hrobarts - I have tried to add more/different information to the docstring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new additions look great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MargaretDuff looking good
Changes
Improves the documentation for IdentityOperator, MatrixOperator and ZeroOperator.
Testing you performed
Related issues/links
Closes #1950
Checklist
[ ] I have implemented unit tests that cover any new or modified functionality[ ] CHANGELOG.md has been updated with any functionality changeContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.
--->