-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skimage requirement for CIL-Demos #1955
Conversation
Signed-off-by: Laura Murgatroyd <[email protected]>
Signed-off-by: Laura Murgatroyd <[email protected]>
Signed-off-by: Laura Murgatroyd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exceptionally bad practice to put requirements in CIL that have nothing to do with CIL (they are not dependencies).
Please put things in CIL-Demos instead.
At most you could put them in CIL's requirements-test
(but not readme etc.) clearly commenting that they're there due to CIL-Demos
/cc @paskino
I think the point was that the docker image will need to have tomopy and scikit-image installed. It uses requirements-test.yml. It has scikit-image but not tomopy. |
Exactly. The ONLY correct way to do this is:
|
Tomopy is no longer required so updating this PR to just add skimage to the CIL-Demos install instructions and I will open another issue with Casper's suggetions |
Signed-off-by: Laura Murgatroyd <[email protected]>
@casperdcl thanks for your suggestions, hopefully this covers everything: #1961 We need a wider discussion / agreement before removing the CIL-Demos install instructions from the CIL readme, so I still need to add skimage to the install instructions in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lauramurgatroyd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Have implemented Casper's suggestions
Description
Add requirement of skimage to CIL-Demos install instructions
Required for the new callbacks notebook
Example Usage
Changes
Testing you performed
Related issues/links
Closes #1956
Checklist
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.
--->