Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add phpstan timeout option #29

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

npo-mmenke
Copy link
Contributor

adds an option to configure the phpstan timeout, see #28

I'm having issues building this locally though... I'm getting the following errors on full-tool-build.sh:

`[ERROR] Could not process "/var/www/html/vendor/symfony/console/Command/LockableTrait.php" file, due to:
"System error: "Scope not available on "PhpParser\Node\Stmt\Expression" node, but is required by a
refactorWithScope() method of "Rector\DowngradePhp80\Rector\Expression\DowngradeMatchToSwitchRector" rule. Fix
scope refresh on changed nodes first"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line: 25

[ERROR] Could not process "/var/www/html/vendor/symfony/service-contracts/ServiceSubscriberTrait.php" file, due to:
"System error: "Scope not available on "PhpParser\Node\Stmt\Expression" node, but is required by a
refactorWithScope() method of "Rector\DowngradePhp80\Rector\Expression\DowngradeMatchToSwitchRector" rule. Fix
scope refresh on changed nodes first"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line: 25

[ERROR] Could not process "/var/www/html/vendor/symfony/service-contracts/ServiceLocatorTrait.php" file, due to:
"System error: "Scope not available on "PhpParser\Node\Expr\Array_" node, but is required by a
refactorWithScope() method of "Rector\DowngradePhp81\Rector\Array_\DowngradeArraySpreadStringKeyRector" rule.
Fix scope refresh on changed nodes first"
Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line: 25

[ERROR] Could not process "vendor/symfony/console/Tester/ApplicationTester.php" file, due to:
"Analyze error: "Class PHPStanBodyscan202407\Symfony\Component\Console\Tester\ApplicationTester was not found
while trying to analyse it - discovering symbols is probably not configured properly.". Include your files in
"$rectorConfig->autoloadPaths([...]);" or "$rectorConfig->bootstrapFiles([...]);" in "rector.php" config.
See https://github.com/rectorphp/rector#configuration".

[ERROR] Could not process "vendor/symfony/console/Tester/CommandTester.php" file, due to:
"Analyze error: "Class PHPStanBodyscan202407\Symfony\Component\Console\Tester\CommandTester was not found while
trying to analyse it - discovering symbols is probably not configured properly.". Include your files in
"$rectorConfig->autoloadPaths([...]);" or "$rectorConfig->bootstrapFiles([...]);" in "rector.php" config.
See https://github.com/rectorphp/rector#configuration".`

On executing the binary the following error occurs:

PHP Fatal error: Uncaught Error: Class "PHPStanBodyscan202407\Illuminate\Container\Container" not found in /var/www/html/src/DependencyInjection/ContainerFactory.php:17

Any idea?

@TomasVotruba
Copy link
Owner

Thanks 👍

Local build is not required, as this script is probably outdated and we only use CI to do the build.
What is required is passing CI.

@npo-mmenke npo-mmenke marked this pull request as ready for review July 11, 2024 12:58
@npo-mmenke
Copy link
Contributor Author

not sure how this works, do I need to do something to trigger the ci again?

@TomasVotruba
Copy link
Owner

@npo-mmenke Its Github's default once you contribute a new repository first time. Not very helpful though https://github.com/orgs/community/discussions/14334

I have to basically confirm everytime you push a commit. Once we merge something, you'll be verified as "known user" and CI will run automatically :)

@npo-mmenke
Copy link
Contributor Author

anything else you need from me here?

@TomasVotruba
Copy link
Owner

Looks good, thanks 👍

@TomasVotruba TomasVotruba merged commit 18d7de5 into TomasVotruba:main Aug 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants