Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player choice pull request #3

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Player choice pull request #3

merged 11 commits into from
Apr 22, 2024

Conversation

Tomansion
Copy link
Owner

Player pawn selection on move

Now implementing the real rules of Santorini, the Player class must now tell which pawn to move.

Thank you @daniPclos for starting the implementation in #2 and doing most of the work.

I've copied your changes and applied the following changes:

  • Made the code valid with Black and Flake8 again
  • Updated the tests to support the new selected pawn parameter
  • Updated the Readme documentation
  • Changed the pawn parameter to be 1 or 2 instead of the pawn number
  • Fixed few bug that I had with situations where a player pawns are stuck and with victories calculations.

@daniPclos
Copy link
Contributor

Hi @Tomansion,

Thanks for fixing the tests, documentation and formatting. I'll try to not forget those in the future. :)
The changes work fine on my side.

I wonder whether you have some kind of platform in place to test and rank new AIs (besides the project's testers)?
It would be nice to get some competition going!

Cheers,
Daniel

@Tomansion
Copy link
Owner Author

The changes work fine on my side.

Perfect, then I'll merge those changes

I wonder whether you have some kind of platform in place to test and rank new AIs (besides the project's testers)?
It would be nice to get some competition going!

Good idea! I make and deploy web applications, we could do some kind of leaderboard and a place to drag and drop players. I'm not planning on doing this anytime soon, but I will look into how other people did it safely.

@Tomansion Tomansion merged commit 6759395 into main Apr 22, 2024
4 checks passed
@daniPclos
Copy link
Contributor

Good idea! I make and deploy web applications, we could do some kind of leaderboard and a place to drag and drop players. I'm not planning on doing this anytime soon, but I will look into how other people did it safely.

Sounds good! I have some basic experience with Flask and React so I would be happy to contribute. There is also an interesting platform for ai development for board and video games called "codinGame". They don't have Santorini yet so it would be possible to deploy it there, although one needs to reach a certain level (by creating successful AIs) to be allowed that possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants