cleanup: Pass moved-from objects by value instead of const ref. #80
+80
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```sh run-clang-tidy -p _build -fix \ $(find . -name "*.h" -or -name "*.cpp" -or -name "*.c" | grep -v "/_build/") \ -checks="-*,modernize-pass-by-value" ```
github-actions
bot
added
the
cleanup
robinlinden
approved these changes
Nov 27, 2024
|
|
||
| Friend::Friend(uint32_t friendId_, const ToxPk& friendPk_, const QString& userAlias_, | ||
| const QString& userName_) | ||
| Friend::Friend(uint32_t friendId_, ToxPk friendPk_, QString userAlias_, const QString& userName_) |
There was a problem hiding this comment.
I know this is what clang-tidy's autofix did, but it's odd that userName_ isn't by-value when the other QStrings are.
| @@ -70,9 +71,9 @@ | |||
| * @param password If empty, the database will be opened unencrypted. | |||
| * Otherwise we will use toxencryptsave to derive a key and encrypt the database. | |||
| */ | |||
| RawDatabase::RawDatabase(const QString& path_, const QString& password, const QByteArray& salt) | |||
| RawDatabase::RawDatabase(QString path_, const QString& password, const QByteArray& salt) | |||
There was a problem hiding this comment.
No by-value+std::move for QByteArray like in other files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is