Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use make_unique and make_shared instead of new. #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 17, 2024

Also replace deprecated C header includes with their C++ versions.

To reproduce:

run-clang-tidy -p _build -fix \
  $(find . -name "*.h" -or -name "*.cpp" | grep -v "/_build/") \
  -checks="-*,modernize-deprecated-headers,modernize-make-shared,modernize-make-unique"

This change is Reviewable

Also replace deprecated C header includes with their C++ versions.

To reproduce:
```sh
run-clang-tidy -p _build -fix \
  $(find . -name "*.h" -or -name "*.cpp" | grep -v "/_build/") \
  -checks="-*,modernize-deprecated-headers,modernize-make-shared,modernize-make-unique"
```
@iphydf iphydf added this to the v1.18.0 milestone Nov 17, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Nov 17, 2024
@iphydf iphydf modified the milestones: v1.18.0, v1.18.x, v1.18.1 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant