Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Re-enable some tests on windows. #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 25, 2024

Some of these aren't working still, mainly because they can't find Qt plugin DLLs.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 25, 2024
@github-actions github-actions bot added the test Adding missing tests, refactoring tests; no production code change label Nov 25, 2024
@iphydf iphydf force-pushed the win-tests branch 2 times, most recently from d36acf1 to 74c4e02 Compare November 25, 2024 01:11
@iphydf iphydf requested a review from a team as a code owner November 25, 2024 01:11
@nurupo
Copy link
Member

nurupo commented Nov 25, 2024

What do you mean "can't find Qt plugin DLLs"? Just put the needed plugin dlls in appropriate directories alongside the .exe file. Plugin dlls typically have their own directories, e.g. platforms, imageformats, iconengines, etc. - you can see a qtox windows release zip having those.

Also, you might need to enable building of the specific plugin in the Windows Qt cross-compilation config if the Qt plugin dll is not being built in the first place.

@iphydf iphydf force-pushed the win-tests branch 5 times, most recently from 6056ec5 to 8989adb Compare November 25, 2024 10:04
Some of these aren't working still, mainly because they can't find Qt
plugin DLLs.
@iphydf
Copy link
Member Author

iphydf commented Nov 26, 2024

What do you mean "can't find Qt plugin DLLs"? Just put the needed plugin dlls in appropriate directories alongside the .exe file. Plugin dlls typically have their own directories, e.g. platforms, imageformats, iconengines, etc. - you can see a qtox windows release zip having those.

Also, you might need to enable building of the specific plugin in the Windows Qt cross-compilation config if the Qt plugin dll is not being built in the first place.

What I mean is that the tests running on CI don't find the plugins because they don't know that we magically put them into /export. Our setup and zip do know that because we coded that into the setup/zip script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests, refactoring tests; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants