fix: actually give the larger incoming NGC custom packets via API to the client #2441
Conversation
zoff99
changed the title
zoff99
force-pushed
the
zoff99/ngc_custom_pkt_size
branch
from
aa225d5
to
d6c39c1
Compare
| @@ -156,6 +156,11 @@ typedef enum Group_Sync_Flags { | |||
| GF_STATE = (1 << 2), // 4 | |||
| } Group_Sync_Flags; | |||
|
|
|||
| typedef enum Group_CustomPkts_Direction { | |||
There was a problem hiding this comment.
I dont think we need an whole enum for 2 states.
There was a problem hiding this comment.
makes it more readable that way. with true/false you never know
There was a problem hiding this comment.
still looks funky next to bool lossless, hmmm
There was a problem hiding this comment.
+1 for enums, make the code much more readable.
pull-request-attention
bot
assigned zoff99 and Green-Sky and unassigned Green-Sky and zoff99
| @@ -156,6 +156,11 @@ typedef enum Group_Sync_Flags { | |||
| GF_STATE = (1 << 2), // 4 | |||
| } Group_Sync_Flags; | |||
|
|
|||
| typedef enum Group_CustomPkts_Direction { | |||
There was a problem hiding this comment.
Why Pkts and not just Packets?
| @@ -156,6 +156,11 @@ typedef enum Group_Sync_Flags { | |||
| GF_STATE = (1 << 2), // 4 | |||
| } Group_Sync_Flags; | |||
|
|
|||
| typedef enum Group_CustomPkts_Direction { | |||
| GC_CUSTOMPKTS_SENDING = (1 << 0), // 1 | |||
There was a problem hiding this comment.
Why are we using bitmasks? There will only ever be two possibilities and never at the same time. I don't mind an enum but the values shouldn't be bit set.
| @@ -6057,6 +6068,7 @@ static bool handle_gc_lossless_packet(const GC_Session *c, GC_Chat *chat, const | |||
| uint8_t packet_type; | |||
| uint64_t message_id; | |||
|
|
|||
|
|
|||
| @@ -4906,11 +4911,17 @@ static int handle_gc_private_message(const GC_Session *c, const GC_Chat *chat, c | |||
| } | |||
|
|
|||
| /** @brief Returns false if a custom packet is too large. */ | |||
| static bool custom_gc_packet_length_is_valid(uint16_t length, bool lossless) | |||
| static bool custom_gc_packet_length_is_valid(uint16_t length, bool lossless, Group_CustomPkts_Direction pkt_direction) | |||
There was a problem hiding this comment.
This whole function should be rewritten with less nesting.
|
i think this one is obsolete now in favor of #2535 |
This change is