Process non ascii symbols #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for your contribution! Unfortunately, there was a bug in the CI so the coding style fixer did not correctly report coding style issues. May I ask you to rebase on the current main branch so you can see the errors? You can already fix them by running |
When executing mb_convert_encoding all not ascii symbols converted to '?' symbol. In that case to levenshtein function passing parameters, contain only '?' symbols. if use function utf8_to_extended_ascii from the comment in https://www.php.net/manual/en/function.levenshtein.php page, all non ascii symbols processed normally
|
i've rebased to main branch and ran |
ausi
reviewed
Mar 18, 2024
ensure that \count($map) is lower than 128 here, or otherwise throw an exception Co-authored-by: Martin Auswöger <[email protected]>
ausi
approved these changes
Mar 18, 2024
|
Thanks @petrovich24! Released as 2.0.2 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing mb_convert_encoding all not ascii symbols converted to '?' symbol. In that case to levenshtein function passing parameters, contain only '?' symbols.
if use function utf8_to_extended_ascii from the comment in https://www.php.net/manual/en/function.levenshtein.php page, all non ascii symbols processed normally